-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Fix some experimental/deprecated hints #88708
[Docs] Fix some experimental/deprecated hints #88708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Android updates look good!
6b098f7
to
44001c2
Compare
For all of these, there's no need to repeat "This is experimental", and explain what "experimental" means because the mere existence of the message infers it. |
Can reword the ones that do slightly :) |
44001c2
to
c19d5b0
Compare
c19d5b0
to
9e6158d
Compare
Thank you! Added these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely more of these won't pop up again now, right?
There are no uses of "experimental" outside of these tags now in my search, or "deprecated" |
Yeah but as this PR needed to happen there may be some others that may be merged without noticing the new |
That's true, but keeping an eye for those, but good point |
Thanks! |
Thank you! |
Two cases from the recent rendering PR that went unnoticed, and some cases that have a deprecated or experimental message but doesn't use the property
Can remove some of those if they are incorrect, but I think they match, if they have the message in the description I don't think there's an issue making it an "official" tag
Left some of the cases in the Android export in a separate commit for simplicity, as they are specific to an API level, will restore them if they're unwanted